Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.18 hard deprecations #203

Merged
merged 2 commits into from
Nov 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions lib/style/deprecations.ex
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,20 @@ defmodule Styler.Style.Deprecations do

def run({node, meta}, ctx), do: {:cont, {style(node), meta}, ctx}

# Deprecated in 1.18
# rewrite patterns of `first..last = ...` to `first..last//_ = ...`
defp style({:=, m, [{:.., _, [_first, _last]} = range, rhs]}), do: {:=, m, [rewrite_range_match(range), rhs]}
defp style({:->, m, [[{:.., _, [_first, _last]} = range], rhs]}), do: {:->, m, [[rewrite_range_match(range)], rhs]}
defp style({:<-, m, [{:.., _, [_first, _last]} = range, rhs]}), do: {:<-, m, [rewrite_range_match(range), rhs]}

defp style({def, dm, [{x, xm, params} | rest]}) when def in ~w(def defp)a and is_list(params),
do: {def, dm, [{x, xm, Enum.map(params, &rewrite_range_match/1)} | rest]}

# Deprecated in 1.18
# List.zip => Enum.zip
defp style({{:., dm_, [{:__aliases__, am, [:List]}, :zip]}, fm, arg}),
do: {{:., dm_, [{:__aliases__, am, [:Enum]}, :zip]}, fm, arg}

# Logger.warn => Logger.warning
# Started to emit warning after Elixir 1.15.0
defp style({{:., dm, [{:__aliases__, am, [:Logger]}, :warn]}, funm, args}),
Expand Down Expand Up @@ -84,6 +98,9 @@ defmodule Styler.Style.Deprecations do

defp style(node), do: node

defp rewrite_range_match({:.., dm, [first, {_, m, _} = last]}), do: {:"..//", dm, [first, last, {:_, m, nil}]}
defp rewrite_range_match(x), do: x

defp add_step_to_date_range?(first, last) do
with {:ok, f} <- extract_date_value(first),
{:ok, l} <- extract_date_value(last),
Expand Down
34 changes: 34 additions & 0 deletions test/style/deprecations_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,40 @@ defmodule Styler.Style.DeprecationsTest do
)
end

test "matching ranges" do
assert_style "first..last = range", "first..last//_ = range"
assert_style "^first..^last = range", "^first..^last//_ = range"
assert_style "first..last = x = y", "first..last//_ = x = y"
assert_style "y = first..last = x", "y = first..last//_ = x"

assert_style "def foo(x..y), do: :ok", "def foo(x..y//_), do: :ok"
assert_style "def foo(a, x..y = z), do: :ok", "def foo(a, x..y//_ = z), do: :ok"
assert_style "def foo(%{a: x..y = z}), do: :ok", "def foo(%{a: x..y//_ = z}), do: :ok"

assert_style "with a..b = c <- :ok, d..e <- :better, do: :ok", "with a..b//_ = c <- :ok, d..e//_ <- :better, do: :ok"

assert_style(
"""
case x do
a..b = c -> :ok
d..e -> :better
end
""",
"""
case x do
a..b//_ = c -> :ok
d..e//_ -> :better
end
"""
)
end

test "List.zip/1" do
assert_style "List.zip(foo)", "Enum.zip(foo)"
assert_style "foo |> List.zip |> bar", "foo |> Enum.zip() |> bar()"
assert_style "foo |> List.zip", "Enum.zip(foo)"
end

describe "1.16 deprecations" do
@describetag skip: Version.match?(System.version(), "< 1.16.0-dev")

Expand Down