Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing infix operators #64

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Conversation

ugurtepecik
Copy link
Contributor

@ugurtepecik ugurtepecik commented Aug 3, 2023

Changelog

  • Added missing infix operators.

Summary

I am uncertain if this is the correct solution, but when I ran mix format, I encountered errors related to the usage of and, or, !=, !==, === operators.

Sample Code Snippet:

((id == "" or id == requested_id) and (type == "" or type == requested_type))
|> foo()

After mix format:

(id == "" or id == requested_id)
|> and(type == "" or type == requested_type)
|> foo()

As you can observe, this syntax is not valid. Therefore, I added these operators in infix_ops list.

Checks

  • Please sign Adobe's CLA if this is your first time contributing to an Adobe open source repo. Thanks!

@ugurtepecik ugurtepecik closed this Aug 3, 2023
@ugurtepecik ugurtepecik reopened this Aug 3, 2023
@novaugust
Copy link
Contributor

thanks for jumping through all those hoops to get this merged! ❤️

@novaugust novaugust merged commit f1032c6 into adobe:main Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants