with statement: drop singleton identity else. closes #84 #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novaugust
commented
Nov 12, 2023
| with :ok <- b(), :ok <- b() do | ||
| :ok | ||
| else | ||
| :what -> :what |
Contributor
Author
There was a problem hiding this comment.
unsure if i want to replace all equivalent nodes, or only variables. letting people specify patterns here at least tells the reader "the caller doesn't have to worry about anything but this value", whereas else error -> error end conveys 0 information and so can be trivially removed.
novaugust
force-pushed
the
me/with-identity-else
branch
from
4a8592e to
12f006c
Compare
novaugust
force-pushed
the
me/with-identity-else
branch
5 times, most recently
from
fd3474e to
c1e2748
Compare
novaugust
force-pushed
the
me/with-identity-else
branch
from
c1e2748 to
3aece4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #84
leaving this as a PR for a bit while I stew