Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-1808 - move action generators to their own repos #206

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

shazron
Copy link
Member

@shazron shazron commented Oct 20, 2022

Related #204

How Has This Been Tested?

  • npm test
  • manual test
    • aio plugins link the app plugin
    • npm link this branch into the app plugin
    • aio app init --standalone-app
    • aio app deploy
    • aio app test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #206 (a8f202f) into master (c324a4b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #206   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        11    -5     
  Lines          371       313   -58     
  Branches        44        44           
=========================================
- Hits           371       313   -58     
Impacted Files Coverage Δ
generators/index.js 100.00% <ø> (ø)
generators/add-action/index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

generators/index.js Show resolved Hide resolved
Copy link
Contributor

@sandeep-paliwal sandeep-paliwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shazron shazron merged commit 57d4404 into master Oct 20, 2022
@shazron shazron deleted the update-action-gens branch October 20, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants