Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rum-explorer): changes input event to keydown-enter for the filter input field #678

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ekremney
Copy link
Member

Description

This update adds the Enter key and blur events now bypass the debounce, triggering an immediate update for better user experience.

Related Issue

none

Motivation and Context

This change improves responsiveness and usability by reducing frequent updates caused by rapid typing in the input field which immediate updates on Enter and blur make the behavior more intuitive for users.

How Has This Been Tested?

on my local

Screenshots (if appropriate):

none

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ekremney ekremney changed the title Input field keydown fix(rum-explorer): changes input event to keydown-enter for the filter input field Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant