Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use setuptools extras for extra dependencies #44

Closed
aslafy-z opened this issue Mar 31, 2021 · 1 comment · Fixed by #91 · May be fixed by #144
Closed

Use setuptools extras for extra dependencies #44

aslafy-z opened this issue Mar 31, 2021 · 1 comment · Fixed by #91 · May be fixed by #144
Labels
enhancement New feature or request

Comments

@aslafy-z
Copy link
Contributor

These integrations https://github.com/adobe/himl#feature-secrets-retrieval depends on external packages which are not required for the basic operation of the package.

What do you think of moving these dependencies (boto, hvac...) to extra_requires ?
https://setuptools.readthedocs.io/en/latest/userguide/dependency_management.html#id7

Then users will be able to install the simple package with pip install himl and add functionnality with pip install himl[vault, aws]
@costimuraru
Copy link
Contributor

That's actually a nice idea. I think we can do something like that.

@danielcoman danielcoman added the enhancement New feature or request label Apr 12, 2021
amuraru added a commit that referenced this issue May 29, 2022
@amuraru
Use setuptools extras for extra dependencies
713141a 
Fixes #44
@amuraru amuraru mentioned this issue May 29, 2022
Merged
amuraru added a commit that referenced this issue May 29, 2022
@amuraru
Use setuptools extras for extra dependencies
538f099 
Fixes #44
amuraru added a commit that referenced this issue May 29, 2022
@amuraru
Use setuptools extras for extra dependencies
40f1675 
Fixes #44
amuraru added a commit that referenced this issue Jun 3, 2022
@amuraru
Use setuptools extras for extra dependencies (#91)
1aa60f6 
Fixes #44
@aslafy-z aslafy-z mentioned this issue Jun 9, 2022
Merged
10 tasks
@aslafy-z aslafy-z mentioned this issue Aug 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@costimuraru @aslafy-z @danielcoman