Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

adobe / himl Public

Notifications You must be signed in to change notification settings
Fork 31
Star 123

Code
Issues 9
Pull requests 10
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: split extras by features #95

Merged

amuraru merged 8 commits into adobe:master from aslafy-z:patch-1

Jun 10, 2022

Merged

feat: split extras by features #95

amuraru merged 8 commits into adobe:master from aslafy-z:patch-1

Jun 10, 2022

Conversation 8 Commits 8 Checks 0 Files changed

Conversation

Copy link

Contributor

aslafy-z commented Jun 7, 2022 •

edited

Loading

Description

Related Issue

Motivation and Context

Allow users to choose which extras should be installed (eg: no need for AWS packages when working only with vault)

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

Sorry, something went wrong.

All reactions

aslafy-z added 3 commits

June 7, 2022 18:26


          feat: split extras by features

629d9ea


          Update README.md

ef50407


          Update Dockerfile

ea141d6

aslafy-z commented

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

aslafy-z commented

View reviewed changes

README.md Outdated Show resolved Hide resolved

aslafy-z commented

View reviewed changes

README.md Show resolved Hide resolved

aslafy-z commented

View reviewed changes

README.md Outdated Show resolved Hide resolved

aslafy-z commented

View reviewed changes

setup.py Outdated Show resolved Hide resolved


          Apply suggestions from code review

b6fc8a1

aslafy-z commented

View reviewed changes

README.md Outdated Show resolved Hide resolved


          Update README.md

9d943c6

aslafy-z commented

View reviewed changes

setup.py Outdated Show resolved Hide resolved


          Update setup.py

ade8031

amuraru approved these changes

View reviewed changes


          Update setup.py

cefafc3

aslafy-z commented

View reviewed changes

setup.py Outdated Show resolved Hide resolved


          Update setup.py

cea20cb

aslafy-z marked this pull request as ready for review

June 9, 2022 09:53

aslafy-z requested a review from amuraru

June 9, 2022 09:53

amuraru approved these changes

View reviewed changes

amuraru merged commit 1be8d3a into adobe:master

aslafy-z deleted the patch-1 branch

June 11, 2022 07:48

aslafy-z restored the patch-1 branch

August 3, 2023 16:51

aslafy-z mentioned this pull request

feat: split extras by features #144

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

amuraru amuraru approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.