i18n breaks usage outside of jsonschema2md repo

[trieloff]

Hi @Claymore1337 it looks like the latest release is broken when used from node_modules of another project:

$ npx jsonschema2md -d src/schemas -o docs

07
info: output directory: /home/circleci/project/docs
info: finished reading all *.schema.json files in /home/circleci/project/src/schemas, beginning processing….
/home/circleci/project/src/schemas/action.schema.json
/home/circleci/project/src/schemas/content.schema.json
/home/circleci/project/src/schemas/context.schema.json
/home/circleci/project/src/schemas/mdast.schema.json
/home/circleci/project/src/schemas/meta.schema.json
/home/circleci/project/src/schemas/position.schema.json
/home/circleci/project/src/schemas/rawrequest.schema.json
/home/circleci/project/src/schemas/request.schema.json
/home/circleci/project/src/schemas/response.schema.json
/home/circleci/project/src/schemas/secrets.schema.json
/home/circleci/project/src/schemas/section.schema.json
unresolved reference: https://ns.adobe.com/helix/pipeline/position
unresolved reference: https://ns.adobe.com/helix/pipeline/mdast
unresolved reference: https://ns.adobe.com/helix/pipeline/meta#/definitions/meta
unresolved reference: https://ns.adobe.com/helix/pipeline/meta#/definitions/meta/properties/title
unresolved reference: https://ns.adobe.com/helix/pipeline/meta#/definitions/meta/properties/intro
unresolved reference: https://ns.adobe.com/helix/pipeline/meta#/definitions/meta/properties/image
unresolved reference: https://ns.adobe.com/helix/pipeline/mdast
unresolved reference: https://ns.adobe.com/helix/pipeline/meta#/definitions/meta/properties/image
unresolved reference: https://ns.adobe.com/helix/pipeline/meta#/definitions/meta/properties/intro
unresolved reference: https://ns.adobe.com/helix/pipeline/meta#/definitions/meta
unresolved reference: https://ns.adobe.com/helix/pipeline/position
unresolved reference: https://ns.adobe.com/helix/pipeline/meta#/definitions/meta/properties/title
/home/circleci/project/src/schemas/textcoordinates.schema.json
Output processed. Trying to make a README.md now
error: ENOENT: no such file or directory, mkdir '/home/circleci/project/lib/locales' {"errno":-2,"code":"ENOENT","syscall":"mkdir","path":"/home/circleci/project/lib/locales"}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @adobe/helix-pipeline@4.0.5 docs: `npx jsonschema2md -d src/schemas -o docs`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @adobe/helix-pipeline@4.0.5 docs script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/circleci/.npm/_logs/2019-07-30T09_41_43_235Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @adobe/helix-pipeline@4.0.5 types: `npm run docs && node bin/schema2ts.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @adobe/helix-pipeline@4.0.5 types script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/circleci/.npm/_logs/2019-07-30T09_41_43_247Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @adobe/helix-pipeline@4.0.5 lint: `npx eslint . && npm run types`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @adobe/helix-pipeline@4.0.5 lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/circleci/.npm/_logs/2019-07-30T09_41_43_257Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @adobe/helix-pipeline@4.0.5 test-ci: `npm run lint && npm run test && codecov`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @adobe/helix-pipeline@4.0.5 test-ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/circleci/.npm/_logs/2019-07-30T09_41_43_267Z-debug.log
Exited with code 1

See also adobe/helix-pipeline#432

[Claymore1337]

@trieloff
I could not reproduce this bug on my environment. I assume that has something to do with the operation system.

I was building the path myself and not over the path.resolve/join like in other code part. I will make a branch with the fix. Is there a way how I could run that test on a branch?

[trieloff]

Just reading the error message

error: ENOENT: no such file or directory, mkdir '/home/circleci/project/lib/locales' {"errno":-2,"code":"ENOENT","syscall":"mkdir","path":"/home/circleci/project/lib/locales"}

it looks like the problem is that lib does not exist, so creating lib/locales won't work.

The bigger question is: why do we have to create the directory anyway?

[Claymore1337]

I found the error. I have setuped the i18n lib in the file readmeWriter.js in the wrong way. Then I saw if i would setup it into the cli.js i just would need to do it once and not twice. So i have moved the init part of the i18n to the cli.js.

Now to your question. The i18n lib will create a file in the provided directory if the file did not exists.

[trieloff]

When run without arguments, then it should just take the i18n file from the project's __dirname instead of creating another output file.

[Claymore1337]

This was exactly the bug at one point I have forgot to use dirname.

[trieloff]

Thank you, @Claymore1337 – much appreciated!

[trieloff]

🎉 This issue has been resolved in version 3.1.1 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀