Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slugger trips over schemas that have a property called title #196

Closed
trieloff opened this issue Jan 14, 2020 · 1 comment
Closed

Slugger trips over schemas that have a property called title #196

trieloff opened this issue Jan 14, 2020 · 1 comment
Labels
bug released

Comments

@trieloff
Copy link
Collaborator

Such as https://github.com/adobe/helix-pipeline/blob/master/src/schemas/meta.schema.json:

(node:666) UnhandledPromiseRejectionWarning: TypeError: Cannot convert object to primitive value
    at Object.meta.(anonymous function) (/code/helix-pipeline/node_modules/@adobe/jsonschema2md/lib/schemaProxy.js:85:65)
    at Object.get (/code/helix-pipeline/node_modules/@adobe/jsonschema2md/lib/schemaProxy.js:97:26)
    at Object.meta.(anonymous function) (/code/helix-pipeline/node_modules/@adobe/jsonschema2md/lib/schemaProxy.js:80:32)
    at Object.get (/code/helix-pipeline/node_modules/@adobe/jsonschema2md/lib/schemaProxy.js:97:26)
    at schema (/code/helix-pipeline/node_modules/@adobe/jsonschema2md/lib/readmeBuilder.js:65:27)
    at map (/code/helix-pipeline/node_modules/ferrum/src/sequence.js:1056:11)
    at map.next (<anonymous>)
    at Function.from (<anonymous>)
    at list (/code/helix-pipeline/node_modules/ferrum/src/sequence.js:799:29)
    at bytype (/code/helix-pipeline/node_modules/@adobe/jsonschema2md/lib/readmeBuilder.js:59:30)
(node:666) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:666) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
@trieloff trieloff added the bug label Jan 14, 2020
trieloff added a commit that referenced this issue Jan 14, 2020
@trieloff
test(slugger): recreate slugger failure when title is an object
66fa1d0 
using example file from helix-pipeline where the issue was first discovered in
adobe/helix-pipeline#552

see #196
@trieloff trieloff mentioned this issue Jan 14, 2020
Merged
trieloff pushed a commit that referenced this issue Jan 14, 2020
@semantic-release-bot
chore(release): 4.0.5 [skip ci]
2878221 
## [4.0.5](v4.0.4...v4.0.5) (2020-01-14)

### Bug Fixes

* **slugger:** fix slugger crash due to title property ([4f0ab31](4f0ab31)), closes [#196](#196)
@trieloff
Copy link
Collaborator Author

🎉 This issue has been resolved in version 4.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trieloff