Path separator on Windows is using backslashes

[storm1ng]

What did you do

Generate schemas on Windows (previously on Unix/Linux)

What did you expect to happen

No changes in URL slashes (preserve regular forward slashes)

What happened

Forward slashes were replaced by backslashes

What's your environment

• Operating System: Windows 10 1803
• node.js version: 12.10.0

Do you have example files:

For this schema

{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "$id": "http://jsonlogic.com/schemas/operators/arithmetic/add.json",

  "title": "+",
  "description": "Addition. Because addition is associative, it happily take as many args as you want. Passing just one argument to + casts it to a number.",

  "type": "object",
  "additionalProperties": false,
  "required": ["+"],
  "properties": {
    "+": {
      "$ref": "http://jsonlogic.com/schemas/common/one-or-more-args.json"
    }
  }
}

I'm getting following Markdown (git diff)

| Abstract            | Extensible | Status         | Identifiable            | Custom Properties | Additional Properties | Access Restrictions | Defined In                                                         |
| :------------------ | ---------- | -------------- | ----------------------- | :---------------- | --------------------- | ------------------- | ------------------------------------------------------------------ |
-| Can be instantiated | No         | Unknown status | Unknown identifiability | Forbidden         | Allowed               | none                | [add.json\*](operators/arithmetic/add.json "open original schema") |
+| Can be instantiated | No         | Unknown status | Unknown identifiability | Forbidden         | Allowed               | none                | [add.json\*](operators\arithmetic\add.json "open original schema") |                  

 ## properties Type                                                                                                                                                                                           

[trieloff]

There might be an easy fix for this: replace this line:

jsonschema2md/lib/index.js

Line 22 in d0d9e82

const npath = require('path');

with an import to path.posix

I don't have a windows VM available, so a fix from my end might take a while, but I'm happy to review PRs.

[storm1ng]

const npath = require('path').posix does not work.
It will change the output but not in the way we want:

-| Abstract            | Extensible | Status         | Identifiable            | Custom Properties | Additional Properties | Access Restrictions | Defined In                                                         |
-| :------------------ | ---------- | -------------- | ----------------------- | :---------------- | --------------------- | ------------------- | ------------------------------------------------------------------ |
-| Can be instantiated | No         | Unknown status | Unknown identifiability | Forbidden         | Allowed               | none                | [add.json\*](operators/arithmetic/add.json "open original schema") |
+| Abstract            | Extensible | Status         | Identifiable            | Custom Properties | Additional Properties | Access Restrictions | Defined In
                                                             |
+| :------------------ | ---------- | -------------- | ----------------------- | :---------------- | --------------------- | ------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| Can be instantiated | No         | Unknown status | Unknown identifiability | Forbidden         | Allowed               | none                | [add.json\*](../C:\eplatform\git-repos\json-logic-js/C:\eplatform\git-repos\json-logic-js\schemas\operators\arithmetic\add.json "open original schema") |

[storm1ng]

A working solution would be to replace the os specific separator (npath.sep) with the posix one (npath.posix.sep):

        const target = npath.relative(
          mddir,
          npath.resolve(schemadir, npath.relative(srcdir, origin)),
        ).split(npath.sep).join(npath.posix.sep);

Not sure though if this covers all use cases.

[trieloff]

🎉 This issue has been resolved in version 4.0.12 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀