Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Req: Relocate definitons. #226

Closed
KyleTryon opened this issue May 26, 2020 · 2 comments
Closed

Req: Relocate definitons. #226

KyleTryon opened this issue May 26, 2020 · 2 comments
Labels
enhancement

Comments

@KyleTryon
Copy link

KyleTryon commented May 26, 2020 •
edited
Loading

What did you do

Construct a schema using multiple definitions in order to clean up the level of nesting in the final schema.

Generate documentation and view the top-level schema.

All of the definition groups appear at the top, above the properties which I would believe to be the main information a user would be looking for.

What did you expect to happen

Definition files could be separate files, when users get to the area that would reference a definition, they could be linked to that reference file.

Alternatively maybe this could just be relocated to the bottom?
@trieloff
Copy link
Collaborator

Moving it to the bottom sounds reasonable.

alainlecluse pushed a commit to alainlecluse/jsonschema2md that referenced this issue Jun 1, 2020
fix: moved definitions to bottom of output file
1b27fff 
adobe#226
@alainlecluse alainlecluse mentioned this issue Jun 1, 2020
Merged
trieloff pushed a commit that referenced this issue Jun 4, 2020
@semantic-release-bot
chore(release): 4.1.3 [skip ci]
1221e7d 
## [4.1.3](v4.1.2...v4.1.3) (2020-06-04)

### Bug Fixes

* moved definitions to bottom of output file ([1b27fff](1b27fff)), closes [#226](#226)
@alainlecluse
Copy link
Contributor

@trieloff I think this issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trieloff @alainlecluse @KyleTryon