Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n is now used in all templates #144

Merged
merged 8 commits into from
Jul 30, 2019
Merged

i18n is now used in all templates #144

merged 8 commits into from
Jul 30, 2019

Conversation

Claymore1337
Copy link
Contributor

Issue: #143

-Added i18n-node as dependency
-Add "i" as console arg and pass all args to the markdown.js.
-Add a translation file and use it in all templates.

A possible todo could be to add a linting rule which did not allow to use plain text in .ejs files

@ghost
Copy link

ghost commented Jul 24, 2019

There were the following issues with this Pull Request

  • Commit: 8babf10
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Jul 24, 2019

There were the following issues with this Pull Request

  • Commit: 8babf10
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 9bd05e7
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@Claymore1337
Copy link
Contributor Author

I saw the

Commit Message Format

block to late and my message is wrong. Is there a way to fix it over git commit --amend ?

@trieloff
Copy link
Collaborator

@Claymore1337 no big deal, I can squash the commit.

@trieloff
Copy link
Collaborator

Looks good so far, but some of the tests are still failing.

@ghost
Copy link

ghost commented Jul 25, 2019

There were the following issues with this Pull Request

  • Commit: 8babf10
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 9bd05e7
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 943c8fb
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Jul 25, 2019

There were the following issues with this Pull Request

  • Commit: 8babf10
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 9bd05e7
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 943c8fb
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: b4c29ec
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Jul 25, 2019

There were the following issues with this Pull Request

  • Commit: 8babf10
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 9bd05e7
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 943c8fb
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: b4c29ec
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@Claymore1337
Copy link
Contributor Author

@trieloff
Could you give me a hint what excatly go wrong here? Cause there is nothing marked on the output

image

And is there a possibility to run the test on windows correctly?

@trieloff
Copy link
Collaborator

Looks like some whitespace issue. You could try to copy the offending file from the "actual" folder into the "expected" folder.

I haven't looked into Windows, but could set up a CI task for that.

Test fix and add description for the README.md file

re adobe#144
@ghost
Copy link

ghost commented Jul 26, 2019

There were the following issues with this Pull Request

  • Commit: 8babf10
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 9bd05e7
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 943c8fb
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: b4c29ec
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@Claymore1337
Copy link
Contributor Author

@trieloff
I finally found the error. Sorry that this took so long 😄

@ghost
Copy link

ghost commented Jul 29, 2019

There were the following issues with this Pull Request

  • Commit: 8babf10
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 9bd05e7
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 943c8fb
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: b4c29ec
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@trieloff trieloff merged commit daa58a2 into adobe:master Jul 30, 2019
@trieloff
Copy link
Collaborator

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants