-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): improve nodejs api #323
Conversation
Codecov Report
@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 98.57% 99.31% +0.74%
==========================================
Files 11 11
Lines 563 588 +25
==========================================
+ Hits 555 584 +29
+ Misses 8 4 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, but I find it too hard to review the unrelated changes and disentangle the substance of the PR.
Please:
- do not change the copyright dates
- do not introduce camel case variable names (open a separate refactoring/style PR if it bothers you too much)
- do not change import orders or import names (same as above)
- make sure the test coverage does not go down
I will review then, as the substance of the PR seems to make sense, it's just hard to see underneath the mountain of other changes.
9ebff10
to
9839b78
Compare
Hi @eduardomourar - thanks for the update, I may need until the week after next to review this. |
No rush, we are doing extensive tests against our schemas in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, but the comment formatting and copyright dates need to stay the way they've been before.
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
In order to make somewhat more extensible to use library with Node.js, we will need to make the following changes:
Related to #300.