-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve typescript return types #102
Open
fedeci
wants to merge
86
commits into
adobe:main
Choose a base branch
from
fedeci:typescript-return-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: launch prep
Merge branch 'master' of github.com:adobe/leonardo
style: fixed issue with tabs indicator color fallback
feat: adding link to demo app in UI
Bumps [serialize-to-js](https://github.com/commenthol/serialize-to-js) from 3.0.0 to 3.0.2. - [Release notes](https://github.com/commenthol/serialize-to-js/releases) - [Commits](commenthol/serialize-to-js@v3.0.0...v3.0.2) Signed-off-by: dependabot[bot] <support@github.com>
style: Updated demo app to a calendar with more colors to demonstrate
style: updated styles of links
…ize-to-js-3.0.2 build(deps): bump serialize-to-js from 3.0.0 to 3.0.2
feat: colorscale as HTML Canvas
style: dropdown width override to correct width
- @adobe/leonardo-contrast-colors@1.0.0-alpha.1 - @adobe/leonardo-ui@1.1.0
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.1 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.1...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* added option for color scales in * updated test for error * updated to allow ratios input as an object
* Added color format output functionality to contrast-colors package * readme update * readme update
- @adobe/leonardo-contrast-colors@1.0.0-alpha.6 - @adobe/leonardo-ui@1.3.0
* feat: add Typescript support * feat: update index.d.ts
- @adobe/leonardo-contrast-colors@1.0.0-alpha.7 - @adobe/leonardo-ui@1.3.1
* added contrast checker to Leonardo * enhancements to checker * fixed converter layout * added conversion support for contrast inputs
* added linear interpolation to resolve alpha transparency for calculating contrast * added missing commits
* fix: remove 'HEX' and 'CAM02p' from color spaces used to interpolate values * feat: add 'NamedColorScale' interface
- @adobe/leonardo-contrast-colors@1.0.0-alpha.8 - @adobe/leonardo-ui@1.3.2
fedeci
changed the title
Improve Typescript return types
Improve typescript return types
Sep 12, 2020
GarthDB
force-pushed
the
main
branch
8 times, most recently
from
March 15, 2024 18:49
500acc1
to
ed3e3c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types returned from 'generateAdaptiveTheme' and 'fixColorValue' now are variable depending on a generic parameter.
eg.
This closes #99
Motivation
This helps the user to better understand what the function will return.
Screenshots
To-do list