Skip to content

148 groupby is parsedefinition driven only it needs to also work with sdk #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

baubakg
Copy link
Member

@baubakg baubakg commented Jul 19, 2024

Description

Related Issue

Fixes #148

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] I have signed the Adobe Open Source CLA.
  • [ x] My code follows the code style of this project.
  • [x ] My change requires a change to the documentation.
  • [ x] I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

@baubakg baubakg linked an issue Jul 19, 2024 that may be closed by this pull request
Copy link

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.78%. Comparing base (cde3efd) to head (c638015).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #150   +/-   ##
=========================================
  Coverage     96.78%   96.78%           
  Complexity      313      313           
=========================================
  Files            20       20           
  Lines           809      809           
  Branches        112      112           
=========================================
  Hits            783      783           
  Misses           15       15           
  Partials         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baubakg baubakg merged commit 592ad71 into main Jul 19, 2024
10 checks passed
@baubakg baubakg deleted the 148-groupby-is-parsedefinition-driven-only-it-needs-to-also-work-with-sdk branch July 19, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GroupBy is ParseDefinition Driven only. It needs to also work with SDK
1 participant