Skip to content

Adapted log-parser to include JSON in the commandline execution #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

baubakg
Copy link
Member

@baubakg baubakg commented Sep 25, 2024

Description

We can export logdata to a JSON file using the commandline

Related Issue

Finishes #173

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] I have signed the Adobe Open Source CLA.
  • [x ] My code follows the code style of this project.
  • [ x] My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [ x] I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.98%. Comparing base (4d655bf) to head (90504b6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #181      +/-   ##
============================================
+ Coverage     96.96%   96.98%   +0.01%     
- Complexity      374      375       +1     
============================================
  Files            22       22              
  Lines           957      961       +4     
  Branches        126      125       -1     
============================================
+ Hits            928      932       +4     
  Misses           18       18              
  Partials         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@baubakg baubakg merged commit 93bf799 into main Sep 25, 2024
10 checks passed
@baubakg baubakg deleted the include-json-in-exec branch September 25, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant