Skip to content

Memory issue #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 24, 2025
Merged

Memory issue #204

merged 19 commits into from
Apr 24, 2025

Conversation

baubakg
Copy link
Member

@baubakg baubakg commented Apr 23, 2025

Description

Related Issue

This PR fixes issue #203

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 92.42424% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.64%. Comparing base (38823b8) to head (481d7b1).

Files with missing lines Patch % Lines
...campaign/tests/logparser/core/ParseGuardRails.java 81.81% 2 Missing ⚠️
...ampaign/tests/logparser/utils/ParseGuardRails.java 86.66% 2 Missing ⚠️
...be/campaign/tests/logparser/utils/MemoryUtils.java 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #204      +/-   ##
============================================
- Coverage     97.00%   96.64%   -0.37%     
- Complexity      377      392      +15     
============================================
  Files            22       25       +3     
  Lines           969     1013      +44     
  Branches        125      126       +1     
============================================
+ Hits            940      979      +39     
- Misses           18       23       +5     
  Partials         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@baubakg baubakg merged commit 3389d5a into main Apr 24, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant