Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't close stream in FileRef.write_to_stream() to comply with Adobe API #14

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

escesare
Copy link

@escesare escesare commented Oct 13, 2022

Description

Remove the line of code in FileRef.write_to_stream() that closes stream, to comply with the API specification:

https://opensource.adobe.com/pdfservices-node-sdk-samples/apidocs/latest/FileRef.html#writeToStream

writeToStream(writableStream)
Writes the contents of this file to writableStream. If this FileRef instance refers to a temporary local file created by the SDK, that temporary file is deleted.
Note: This method does not close the writableStream.

Related Issue

https://github.com/adobe/pdfservices-python-sdk/issues/13

Tasks

  • I have signed the CLA.
  • I have written tests and verified that they fail without my change.

@escesare escesare changed the base branch from master to beta October 13, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant