Bar on click #400
Bar on click #400
Conversation
…ned for bar stories
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-400 |
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-400 |
Bar on click
|
I think you are missing the |
| @@ -113,6 +114,7 @@ export const getStackedDimensionEncodings = (props: BarSpecProps): RectEncodeEnt | |||
| const { dimensionAxis, rangeScale, dimensionScaleKey } = getOrientationProperties(orientation); | |||
|
|
|||
| return { | |||
| cursor: getCursor(props.children, props), | |||
There was a problem hiding this comment.
| cursor: getCursor(props.children, props), |
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-400 |
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-400 |
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-400 |
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-400 |
|
@pratyushbanerjee do you have any idea why the sonarcloud code coverage percentage has worked on each of your PRs but isn't working on this one? Long shot but curious if you might have any idea. |
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-400 |
I see some tests, strange that it shows no coverage. |
Your PRs have the coverage loading and if you open the sonar details in sonarcloud it looks correct. This PR and many other show 0% and when you open the details in sonar cloud, it states that the coverage requires additional setup. 
|
|
They use the same sonar cloud setup. I can't figure out what is different about the PRs which would make yours work but others don't. |
|
I see this in the sonar action logs: |
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-400 |
2 similar comments
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-400 |
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-400 |
|
|
Finally figured it out. |
Description
This change provides
onClickhandling to bar chart elements (i.e. Bar, DodgedBar, etc.) to allow bar element data to be exposed on different components beyond ChartPopover or ChartToolTip.Related Issue
onClick prop for Chart components
Motivation and Context
onClickprop support for chart element components will enable chart info features that expose chart data on components outside of ChartPopover or ChartToolTip.How Has This Been Tested?
Screenshots (if appropriate):
Screen.Recording.2024-09-03.at.9.13.12.AM.mov
Types of changes
Checklist: