Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chart item selection options #412

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

rich-b
Copy link

@rich-b rich-b commented Sep 19, 2024

Adds the option to select how highlighting works for popovers.

Description

Previously, only a single item could be highlighted when clicking on a chart element. This change allows highlighting by series, dimension, or item.

This is the first of many changes required to bring this capability to life. It is mostly working with Bar charts only at this point.

Related Issue

#374

Motivation and Context

Teams want to be able to click on an item within a dimension and effectively select and show information for the dimension, not for the single datum. This could also be useful for series data.

How Has This Been Tested?

  • Updated existing tests
  • Added new test coverage for new code

Screenshots (if appropriate):

image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

Copy link

Copy link

@marshallpete
Copy link
Member

Looks great to me!

@marshallpete marshallpete merged commit 0edd284 into adobe:main Sep 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants