Cache locale dict lest child hooks always re-render (#6185)

* Cache locale dict lest child hooks always re-render * Update context.tsx * fix lint --------- Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Robert Snow <snowystinger@gmail.com> Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
adobe · May 16, 2024 · d80999e · d80999e · rspbot · May 16, 2024
1 parent b294de8
commit d80999e
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/packages/@react-aria/i18n/src/context.tsx b/packages/@react-aria/i18n/src/context.tsx
@@ -30,10 +30,16 @@ export function I18nProvider(props: I18nProviderProps) {
   let {locale, children} = props;
   let defaultLocale = useDefaultLocale();
 
-  let value: Locale = locale ? {
-    locale,
-    direction: isRTL(locale) ? 'rtl' : 'ltr'
-  } : defaultLocale;
+  let value: Locale = React.useMemo(() => {
+    if (!locale) {
+      return defaultLocale;
+    }
+
+    return {
+      locale,
+      direction: isRTL(locale) ? 'rtl' : 'ltr'
+    };
+  }, [defaultLocale, locale]);
 
   return (
     <I18nContext.Provider value={value}>