Update useControlledState for StrictMode #1375
Conversation
The current useControlledState has side effects, this causes an issue StrictMode
|
Build successful! 🎉 |
| }; | ||
| setStateValue(updateFunction); | ||
| let oldValue = stateRef.current; | ||
| let interceptedValue = value(oldValue); |
There was a problem hiding this comment.
This line doesn't seem like it is the same. I'm having trouble figuring out what the expected different between oldValue and stateRef.current in the original code would be and what they are virtually the same in the current code.
In addition, the comment for this section of code seems out of date.
There was a problem hiding this comment.
ah, yep, that comment is now out of date
and yes, it's not quite the same as before, which is why we've pulled it out into its own PR, the issue was that the old way of doing it had a side effect
it used to update the state, once that update was complete, it would call onChange
now it queues the state update and calls onChange, possibly before the state has been committed
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
An update, so far neither this nor the original behavior is quite correct. We're still looking into it. |
|
Build successful! 🎉 |
|
Closing because we've determined we cannot implement this feature and the current implementation has a bug, we'll be deprecating the set state callback functionality, see #2320 for details along with its PR to deprecate which shows how we'll work around this issue for ourselves |
The current useControlledState has side effects, this causes an issue StrictMode
See initial work here https://github.com/adobe/react-spectrum/compare/tests-strict-mode#diff-927eebaa6f590e895634eae7f762db38e91f5f30a71fb8960c620cabfa59d058L50
Closes #1375, #1440, #1611
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: