Fixing useAsyncList loadMore skip logic #1829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug occured in combobox where selecting an option and then quickly opening the menu again caused the list to have duplicate entries. This was because we now rely on a loadingState ref that would update to "error" since the loadMore from the first opening of the menu was canceled by the filtering caused by the option selection, allowing loadMore to trigger again instead of being skipped when opening the menu again.Also moved the settimeout (for simulated long fetch times) before the fetch so requests would get propely canceled, otherwise the fetch could finish early
|
Build successful! 🎉 |
track if any loadMore or filtering operations are happening via Set of abortControllers and skip if so
|
Build successful! 🎉 |
LFDanLu
changed the title
LFDanLu
requested review from
dannify,
devongovett and
snowystinger
as code owners
|
Build successful! 🎉 |
|
Build successful! 🎉 |
| @@ -230,6 +234,12 @@ function reducer<T, C>(data: AsyncListState<T, C>, action: Action<T, C>): AsyncL | |||
| items: action.type === 'loading' ? [] : data.items, | |||
| abortController: action.abortController | |||
| }; | |||
| case 'loadingMore': | |||
| // If already loading more and another loading more is triggered, abort the new load more. | |||
There was a problem hiding this comment.
Can you just add a little bit more about "the cursor hasn't been updated so they are duplicate requests"?
|
Build successful! 🎉 |
devongovett
approved these changes
Apr 22, 2021
majornista
pushed a commit
to majornista/react-spectrum-v3
that referenced
this pull request
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: