Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make useObjectRef use useLayoutEffect #2458

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Make useObjectRef use useLayoutEffect #2458

merged 1 commit into from
Oct 18, 2021

Conversation

solimant
Copy link
Collaborator

Relates to #2293 (comment)

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

yarn test

🧢 Your Project:

Adobe/RSP

@solimant solimant mentioned this pull request Oct 16, 2021
Merged
5 tasks
@adobe-bot
Copy link

Build successful! 🎉

snowystinger
snowystinger previously approved these changes Oct 16, 2021
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@snowystinger snowystinger dismissed their stale review October 16, 2021 19:34

lint is failing

@adobe-bot
Copy link

Build successful! 🎉

@solimant
Copy link
Collaborator Author

@snowystinger - all good now.

reidbarber
reidbarber approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snowystinger snowystinger merged commit 2c09f1e into main Oct 18, 2021
@snowystinger snowystinger deleted the i834_followup branch October 18, 2021 20:03
@solimant solimant linked an issue Oct 27, 2021 that may be closed by this pull request
@react-aria: forwardRef support #834
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@reidbarber reidbarber reidbarber approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

@dannify dannify Awaiting requested review from dannify

@devongovett devongovett Awaiting requested review from devongovett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@react-aria: forwardRef support
5 participants
@solimant @adobe-bot @snowystinger @reidbarber @LFDanLu