Skip to content

Conversation

@devongovett
Copy link
Member

@devongovett devongovett commented Feb 16, 2022

#2857

Two issues:

  1. Browserslist was not picked up by Parcel because it was not in the package.json of each package. The root package.json was not used. Instead, we can move the browserslist to a .browserslistrc file in the root so that we don't need to repeat it. This fixes private class fields being compiled.
  2. We need to lower our browser targets to a browser version that doesn't support optional chaining and nullish coalescing because webpack 4 is still widely used and doesn't support them. At some point in the future we will raise this again, so we encourage all users to upgrade webpack soon if possible.

@adobe-bot
Copy link

Build successful! 🎉

Comment on lines +1 to +4
chrome >= 79
firefox >= 85
safari >= 13
edge >= 88
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only chrome needed a drop in supported version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah just need to drop at least one down so this doesn't match: https://caniuse.com/?search=nullish%20coal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants