-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom cursor icons back #3649
Conversation
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, something up with the docs build not sure what, but I did verify the the custom icons work locally
Nooooo, that's the original issue that caused me to revert the custom icons. Unfortunately it's a race condition, so I thought when several builds passed that the parcel update had fixed it, but it looks like that was too optimistic. |
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there is a grey outline around the cursor in Safari but should be fine IMO
following up on the Safari scaled-up issue separately |
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
Closes
Adds custom cursor icons back
We addressed parcel issue with a workaround to prevent Parcel from overwriting its assets that it loads into both browser and node environment. See parcel-bundler/parcel#5985 (comment) for more information
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: