-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable strict mode toggle in storybook #3870
Conversation
the globals are updating anymore for some reason...
Reopening due to provider breaking in stories upon save (components using useProvider will complain that |
core issue is with react fast refresh in parcel, fix to be patched there eventually. For now this is a stopgap fix, see vitejs/vite#3301 for a similar issue
Note that saving changes in certain files (FocusScope) may cause the storybook to lag a bit, most likely due to some fast refresh shenanigans. At least it doesn't crash anymore though, final fix will be done in Parcel |
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
Test locally, toggle strict mode in storybook via the toolbar at the top. Check that stories with overlays break when strict mode is enabled
🧢 Your Project:
RSP