Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strict mode toggle in storybook #3870

Merged
merged 14 commits into from
Jan 5, 2023
Merged

Enable strict mode toggle in storybook #3870

merged 14 commits into from
Jan 5, 2023

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Dec 21, 2022

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test locally, toggle strict mode in storybook via the toolbar at the top. Check that stories with overlays break when strict mode is enabled

🧢 Your Project:

RSP

@LFDanLu
Copy link
Member Author

LFDanLu commented Dec 21, 2022

Reopening due to provider breaking in stories upon save (components using useProvider will complain that scale isn't defined anymore). This issue seems to happen on main already but only intermittently, adding the strict mode decorator seems to make it happen a lot more though

core issue is with react fast refresh in parcel, fix to be patched there eventually. For now this is a stopgap fix, see vitejs/vite#3301 for a similar issue
@LFDanLu LFDanLu changed the title (WIP) Enable strict mode toggle in storybook Enable strict mode toggle in storybook Jan 4, 2023
@LFDanLu
Copy link
Member Author

LFDanLu commented Jan 4, 2023

Note that saving changes in certain files (FocusScope) may cause the storybook to lag a bit, most likely due to some fast refresh shenanigans. At least it doesn't crash anymore though, final fix will be done in Parcel

@LFDanLu LFDanLu merged commit bb9f65f into main Jan 5, 2023
@LFDanLu LFDanLu deleted the strict_mode_per_story branch January 5, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants