Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add codemod for ActionGroup #7396

Merged
merged 4 commits into from
Nov 20, 2024
Merged

feat: Add codemod for ActionGroup #7396

merged 4 commits into from
Nov 20, 2024

Conversation

devongovett
Copy link
Member

  • Converts <ActionGroup selectionMode="none"> to <ActionButtonGroup>
  • Converts <ActionGroup selectionMode="single | multiple"> to <ToggleButtonGroup>
  • Converts key to id where needed
  • Converts dynamic collections (with items prop and function child) to items.map, adding implicit key and id props where needed
  • Converts onAction on root to onPress function on each item that calls the original onAction with the key
  • Converts disabledKeys on the root to isDisabled prop on each item
  • Comments out props that aren't supported yet, related to collapse behavior

@rspbot
Copy link

rspbot commented Nov 19, 2024

Build successful! 🎉

reidbarber
reidbarber previously approved these changes Nov 19, 2024
View reviewed changes
@devongovett
Merge branch 'main' of github.com:adobe/react-spectrum into actiongro…
ccedca0 
…up-codemods

# Conflicts:
#	packages/dev/codemods/src/s1-to-s2/src/codemods/changes.ts
#	packages/dev/codemods/src/s1-to-s2/src/codemods/transforms.ts
@devongovett
Fix Item and ActionGroup imports
c581c65
@rspbot
Copy link

rspbot commented Nov 20, 2024

Build successful! 🎉

@devongovett devongovett added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 52bf91b Nov 20, 2024
30 checks passed
@devongovett devongovett deleted the actiongroup-codemods branch November 20, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LFDanLu LFDanLu LFDanLu approved these changes

@snowystinger snowystinger snowystinger approved these changes

@reidbarber reidbarber reidbarber left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devongovett @rspbot @snowystinger @reidbarber @LFDanLu