docs: Improve Menu selection group story #7419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
approved these changes
Nov 21, 2024
| </MenuSection> | ||
| </Menu> | ||
| </MenuTrigger> | ||
| ); | ||
| }; | ||
|
|
||
| SelectionGroups.parameters = { |
There was a problem hiding this comment.
just an fyi, this is a deprecated syntax for whenever we go to storybook 8
you can make a story
const SelectionGroups = {
render: (args) => <SelectionGroupsOriginalFunction {...args} />,
parameters...
}
but they don't like it when you make a function the story and then set parameters on that function object
There was a problem hiding this comment.
that syntax is unfortunate because it breaks react fast refresh (story exports are no longer valid react components). 😢
ktabors
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the menu selection group story a more real-world example