feat: Update to Tailwind v4 #7669
Open
+1,622
−1,214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
force-pushed
the
tailwind4
branch
from
66d7f3f to
57bcefe
Compare
1 similar comment
1 similar comment
.circleci/config.yml
Outdated
| filters: | ||
| branches: | ||
| only: main | ||
| # filters: |
There was a problem hiding this comment.
waiting for it to be approved first 😄
There was a problem hiding this comment.
yeah, this is more of a reminder since I always worry I'll forget
| @@ -0,0 +1,19 @@ | |||
| diff --git a/dist/transformer.d.ts b/dist/transformer.d.ts | |||
There was a problem hiding this comment.
how long is this going to be around? will other users need to do the same patch?
There was a problem hiding this comment.
until heroui-inc/tailwind-variants#239 is fixed.
| @@ -135,6 +136,7 @@ async function build() { | |||
| fs.copySync(path.join(__dirname, '..', 'starters'), path.join(dir, 'starters')); | |||
| fs.copySync(path.join(__dirname, '..', '.yarn', 'releases'), path.join(dir, '.yarn', 'releases')); | |||
| fs.copySync(path.join(__dirname, '..', '.yarn', 'plugins'), path.join(dir, '.yarn', 'plugins')); | |||
| fs.copySync(path.join(__dirname, '..', '.yarn', 'patches'), path.join(dir, '.yarn', 'patches')); | |||
There was a problem hiding this comment.
could probably do what we do for buildBranchAPI and just copy everything in .yarn instead of picking and choosing
snowystinger
previously approved these changes
Jan 27, 2025
|
hmm, seems that |
snowystinger
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7661, closes #6127, closes #7263, closes #5800, closes #5642
This updates the
tailwindcss-react-aria-componentsplugin, the docs homepage and examples, the Tailwind starter kit, and example apps to Tailwind v4.The plugin will need to be released as a major version bump. 1.x will work with Tailwind v3, and 2.x will work with Tailwind v4. This is because Tailwind made some internal changes that we needed to account for:
:merge()selector is no longer supported.groupandpeervariants as Tailwind will automatically generate these for all variants.hoverOnlyWhenSupportedoption was removed and is now the default.One additional challenge is that variants added by our plugin are no longer ordered in the same way. Unfortunately that means variants like
disabled:will no longer override other variants unless you stack them. Not sure if there is a way around this.