fix: colspan build #7780
Merged
fix: colspan build #7780
+178
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
commented
Feb 18, 2025
| @@ -5041,11 +5040,3 @@ export let tableTests = () => { | |||
| }; | |||
|
|
|||
| describe('TableView', tableTests); | |||
|
|
|||
| describe('TableView with expandable rows flag on', function () { | |||
There was a problem hiding this comment.
I've just moved these to another file so that the tests run faster
snowystinger
commented
Feb 18, 2025
| @@ -79,20 +79,6 @@ export class GridCollection<T> implements IGridCollection<T> { | |||
|
|
|||
| if (last) { | |||
| last.nextKey = null; | |||
|
|
|||
| if (rowHasCellWithColSpan && node.type === 'item') { | |||
There was a problem hiding this comment.
moved this check back to Table's domain, it's old collections, so not too worried about colSpan on anything other than Tables in v3
it was counting something about expandable rows as an extra column in the dynamic rendering, though I'm not entirely sure why
yihuiliao
approved these changes
Feb 18, 2025
reidbarber
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
noticed that our verdaccio build on main was failing
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: