docs: Use autocomplete docs example #7959
Conversation
snowystinger
force-pushed
the
useAutocomplete-docs-example
branch
from
b68cb41 to
3b008de
Compare
snowystinger
changed the title
| ListBox, | ||
| ListBoxItem, | ||
| useFilter, | ||
| UNSTABLE_InternalAutocompleteContext |
There was a problem hiding this comment.
Seems like the main thing to determine is whether we want to export this or if we want to change approaches. For example, we could consider providing ListBoxContext and MenuContext instead of having those components consume InternalAutocompleteContext. Not sure which is better. The same kind of thing applies to TextFieldContext and SearchFieldContext and we chose the opposite approach there.
There was a problem hiding this comment.
Yeah, that's a good question. I like the idea that users aren't restricted to our components (without basically implementing what is in this page to add/remove other contexts).
I'm not sure why we went the other way on the inputs, do you or @LFDanLu have a short summary of that? Or did it just kind of happen?
There was a problem hiding this comment.
I don't quite remember the exact reasoning, but I recall there being a concern with how many collection components may end up being supported by Autocomplete (table, gridlist, listbox, etc) and thus the number of individual contexts that would be needed vs a single one. I'd be happy to shift to individual contexts if only to reuse the existing collection contexts + match our TextField/SearchField context usage here
There was a problem hiding this comment.
Technically we have the same issue with TextField/SearchField, it's possible there may be other ways to control the filter (maybe a predefined set of radio options/tags?)
So how do we want to handle that as well?
There was a problem hiding this comment.
it feels like input fields are smaller in number (radios/tags would take a separate set of props than the ones coming via textFieldProps from useAutocomplete) but we'd still use individual contexts there (aka radioGroupContext/tagGroupContext or something)
## API Changes
react-aria-components/react-aria-components:UNSTABLE_InternalAutocompleteContext+UNSTABLE_InternalAutocompleteContext {
+ UNTYPED
+} |
dannify
moved this from 👀 In Review
to 🛑 Blocked / Needs More Info
in RSP Component Milestones
|
Closing as this is actively being rewritten |
github-project-automation
bot
moved this from 🛑 Blocked / Needs More Info
to ✅ Done
in RSP Component Milestones
4 participants
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: