Skip to content

feat(RAC): Expose useRenderProps hook #8013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2025

Conversation

sebald
Copy link
Contributor

@sebald sebald commented Mar 31, 2025

Hey, here's a simple addition to the RAC API: by exposing useRenderProps, RAC users can build their own components that integrate more seamlessly with other RAC components.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Sorry, something went wrong.

sebald added 3 commits March 31, 2025 10:25

Verified

This commit was signed with the committer’s verified signature. The key has expired.
jhpratt Jacob Pratt
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary approval, will bring up with the team. Thanks for the PR.

Some of this work will also be done when we redo our docs site with a focus on how to creating more custom components that fit naturally in with RAC.

Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok. I guess the only question we had was whether including data-rac as we currently do would be unexpected for third party components.

@snowystinger snowystinger added this pull request to the merge queue Apr 18, 2025
@snowystinger
Copy link
Member

merged, if we decide to change the data-rac we can follow that up

Merged via the queue into adobe:main with commit a166aaa Apr 18, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants