Skip to content

fix: RAC Numberfield scrolling with stepper buttons #8474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 8, 2025
Merged

fix: RAC Numberfield scrolling with stepper buttons #8474

merged 7 commits into from
Oct 8, 2025
+86 −9

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Jun 30, 2025 •
edited
Loading

Closes #8472

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger mentioned this pull request Jun 30, 2025
Closed
@rspbot
Copy link

rspbot commented Jun 30, 2025

Build successful! 🎉

reidbarber
reidbarber previously approved these changes Jul 7, 2025
View reviewed changes
@rspbot
Copy link

rspbot commented Jul 9, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jul 11, 2025

Build successful! 🎉

@devongovett
Copy link
Member

This conflicts with their comment: #8472 (comment)

@snowystinger snowystinger force-pushed the fix-numberfield-docs-scrolling branch 2 times, most recently from 1245f3c to fb1c64f Compare August 22, 2025 03:31
@snowystinger
Merge branch 'main' into fix-numberfield-docs-scrolling
ff1dc2b 
# Conflicts:
#	packages/react-aria-components/docs/NumberField.mdx
@rspbot
Copy link

rspbot commented Aug 22, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Aug 22, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Aug 22, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Aug 22, 2025

Build successful! 🎉

@snowystinger
Copy link
Member Author

snowystinger commented Aug 22, 2025 •
edited
Loading

This conflicts with their comment: #8472 (comment)

@devongovett
See if the new changes feel better to you. It's definitely more complicated now, but matches with what the user expects I believe.

@rspbot
Copy link

rspbot commented Aug 22, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Aug 27, 2025

Build successful! 🎉

yihuiliao
yihuiliao approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on iphone

if folks want to test on their phones, here's a tiny url to the docs: https://tinyurl.com/5ycrmhuy

@rspbot
Copy link

rspbot commented Sep 11, 2025

Build successful! 🎉

reidbarber
reidbarber approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snowystinger snowystinger added this pull request to the merge queue Oct 8, 2025
Merged via the queue into main with commit ac7ce78 Oct 8, 2025
32 checks passed
@snowystinger snowystinger deleted the fix-numberfield-docs-scrolling branch October 8, 2025 02:22
devongovett pushed a commit that referenced this pull request Oct 9, 2025
@snowystinger @devongovett
fix: RAC Numberfield scrolling with stepper buttons (#8474)
284649d 
* fix: RAC Numberfield scrolling with stepper buttons

* trigger inc/dec on press end instead of start, cancel if there's a touch scroll

* fix comment

* update movement threshold for better feel, make scroll delay longer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbarber reidbarber reidbarber approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees

No one assigned

Labels

needs testing ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NumberField buttons trigger change when scrolling on touch devices

5 participants

@snowystinger @rspbot @devongovett @reidbarber @yihuiliao