Skip to content

Conversation

snowystinger
Copy link
Member

Closes #5953

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Jul 7, 2025

@rspbot
Copy link

rspbot commented Jul 9, 2025

# Conflicts:
#	packages/@react-spectrum/s2/stories/Dialog.stories.tsx
@rspbot
Copy link

rspbot commented Jul 11, 2025

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor point but doesn't seem like textareas follow this select behavior on tab natively: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/textarea. Not too bothered either way tbh

@snowystinger
Copy link
Member Author

minor point but doesn't seem like textareas follow this select behavior on tab natively: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/textarea. Not too bothered either way tbh

good catch, I'll update to only be for HTMLInputElements for now

@rspbot
Copy link

rspbot commented Jul 26, 2025

@rspbot
Copy link

rspbot commented Jul 26, 2025

LFDanLu
LFDanLu previously approved these changes Jul 28, 2025
# Conflicts:
#	packages/@react-aria/autocomplete/src/useAutocomplete.ts
@rspbot
Copy link

rspbot commented Aug 22, 2025

@rspbot
Copy link

rspbot commented Aug 27, 2025

@rspbot
Copy link

rspbot commented Sep 11, 2025

Build successful! 🎉

@snowystinger snowystinger added this pull request to the merge queue Sep 17, 2025
Merged via the queue into main with commit 7df2296 Sep 17, 2025
32 checks passed
@snowystinger snowystinger deleted the fix-focus-behavior-on-inputs-in-focusscope branch September 17, 2025 20:49
snowystinger added a commit that referenced this pull request Sep 22, 2025
snowystinger added a commit that referenced this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can input receive focus differently in a popover scenario
4 participants