-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: Focus behaviour on inputs inside a FocusScope #8498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Focus behaviour on inputs inside a FocusScope #8498
Conversation
Build successful! 🎉 |
Build successful! 🎉 |
# Conflicts: # packages/@react-spectrum/s2/stories/Dialog.stories.tsx
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor point but doesn't seem like textareas follow this select behavior on tab natively: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/textarea. Not too bothered either way tbh
good catch, I'll update to only be for HTMLInputElements for now |
Build successful! 🎉 |
Build successful! 🎉 |
# Conflicts: # packages/@react-aria/autocomplete/src/useAutocomplete.ts
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
This reverts commit 7df2296.
Closes #5953
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: