Skip to content

Conversation

reidbarber
Copy link
Member

  • Reverts S2 Modal position change
  • Fixes S2 Docs mobile menu modal position that relied on that
  • Fix types for S2 Modal

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@LFDanLu LFDanLu enabled auto-merge October 9, 2025 22:48
@rspbot
Copy link

rspbot commented Oct 9, 2025

@LFDanLu LFDanLu added this pull request to the merge queue Oct 9, 2025
Merged via the queue into main with commit a6f0d45 Oct 9, 2025
32 checks passed
@LFDanLu LFDanLu deleted the fix-s2-docs-mobile-position branch October 9, 2025 23:02
LFDanLu pushed a commit that referenced this pull request Oct 9, 2025
* revert S2 modal position change

* fix S2 docs menu modal position

* s2: fix ModalProps types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants