docs: Fix docs issues #9021
Merged
docs: Fix docs issues #9021
+18
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devongovett
commented
Oct 10, 2025
devongovett
commented
- Error page shouldn't be in the sidenav
- Tried to add cache control headers when uploading files in azure so I don't need to manually purge the CDN cache
- Fixed OG image paths based on public url
- Fixed link clicks to external links outside public url base path
|
Build successful! 🎉 |
LFDanLu
previously approved these changes
Oct 10, 2025
|
Build successful! 🎉 |
|
Build successful! 🎉 |
LFDanLu
reviewed
Oct 10, 2025
There was a problem hiding this comment.
looks like the og images are still malformed? https://www.opengraph.xyz/url/https%3A%2F%2Freactspectrum.blob.core.windows.net%2Freactspectrum%2F8fb56f3949e7e5b0cdf4a7d9d9d6f8e0ce866d12%2Fs2-docs%2Fs2%2FButtonGroup.html
|
Build successful! 🎉 |
reidbarber
approved these changes
Oct 10, 2025
LFDanLu
approved these changes
Oct 10, 2025
devongovett
added a commit
that referenced
this pull request
Oct 10, 2025
* Hide error page from side nav * Set cache control headers in azure * Fix og image paths * Fix link clicks outside public url * add missing vanilla css dep * Fix og image paths * use environment variable for public url? --------- Co-authored-by: Daniel Lu <dl1644@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.