Skip to content

feat(RAC): SearchField: add readonly/required render props #9025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2025
Merged

feat(RAC): SearchField: add readonly/required render props #9025

merged 3 commits into from
Oct 20, 2025
+15 −1

Conversation

lixiaoyan
Copy link
Contributor

@lixiaoyan lixiaoyan commented Oct 13, 2025 •
edited
Loading

Addresses #6151

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

reidbarber
reidbarber requested changes Oct 20, 2025
View reviewed changes
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good! Just one small suggestion for the JSdoc

@LFDanLu LFDanLu enabled auto-merge October 20, 2025 17:20
@LFDanLu LFDanLu added this pull request to the merge queue Oct 20, 2025
Merged via the queue into adobe:main with commit f48d2c8 Oct 20, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbarber reidbarber reidbarber approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lixiaoyan @reidbarber @LFDanLu