Skip to content

fix: mcp improvements #9034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 15, 2025
Merged

fix: mcp improvements #9034

merged 5 commits into from
Oct 15, 2025
+73 −28

Conversation

reidbarber
Copy link
Member

  • Added library prefix to tools (some MCP clients like Cursor don't namespace servers, so if you have both servers running, it would call the wrong tool often)
  • Removed id from tool responses (implementation detail)
  • Renamed title to name for consistency

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Oct 14, 2025

Build successful! 🎉

LFDanLu
LFDanLu approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question, forget if we already discussed this

packages/dev/mcp/src/index.ts
// CDN base for docs. Can be overridden via env variable.
const DEFAULT_CDN_BASE = process.env.DOCS_CDN_BASE
?? 'https://reactspectrum.blob.core.windows.net/reactspectrum/7d2883a56fb1a0554864b21324d405f758deb3ce/s2-docs';
?? 'https://reactspectrum.blob.core.windows.net/reactspectrum/a22a0aed3e97d0a23b9883679798b85eed68413d/s2-docs';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that we deployed, do we wanna point to the beta docs link?

@reidbarber reidbarber added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main with commit 49bb12c Oct 15, 2025
32 checks passed
@reidbarber reidbarber deleted the mcp-improvements branch October 15, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snowystinger snowystinger snowystinger approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reidbarber @rspbot @snowystinger @LFDanLu