Skip to content

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Oct 21, 2025

This reverts commit 591d1f8. A regression was found in the new S2 docs where due to nested scroll regions the scrollIntoView code was causing a parent scroll region to over scroll.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test the S2 CardView/GridList examples and verify that keyboard navigating down through the items only cause the parent collection component to scroll items into view

🧢 Your Project:

RSP

@LFDanLu LFDanLu changed the title Revert "fix: scrollIntoView should respect scroll-margin (#8715)" fix: Revert "fix: scrollIntoView should respect scroll-margin (#8715)" Oct 21, 2025
@rspbot
Copy link

rspbot commented Oct 21, 2025

@LFDanLu LFDanLu added this pull request to the merge queue Oct 22, 2025
Merged via the queue into main with commit ecd2291 Oct 22, 2025
32 of 33 checks passed
@LFDanLu LFDanLu deleted the revert_8715 branch October 22, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants