Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update push.bzl #90

Merged
merged 10 commits into from
Apr 22, 2022
Merged

Update push.bzl #90

merged 10 commits into from
Apr 22, 2022

Conversation

uajith
Copy link
Contributor

@uajith uajith commented Apr 14, 2022 •
edited
Loading

Removing tag as well.
On Bazel 5.0, tag also became obsolete.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@uajith
Update push.bzl
2ee6a05 
Removing `tag` as well. 
On Bazel 5.0, tag also became obsolete.
@uajith uajith requested a review from a team as a code owner April 14, 2022 06:12
@uajith
Copy link
Contributor Author

uajith commented Apr 14, 2022

The error seen in Bazel 5.0 is

image

The error says

Error: unexpected keywords stamp, stamp, stamp, stamp_inputs, tag in call to instantiate provider PushInfo

This means we need to delete the keyword tag as well from the mentioned file.

@uajith
Copy link
Contributor Author

uajith commented Apr 14, 2022

Detailed error : https://jenkins.dev.k8s.tubemogul.info/blue/organizations/jenkins/monorepo%2Ftm-repo/detail/feature%2FCICD-177-Bazel5_Upgrade/21/pipeline/

kzadorozhny
kzadorozhny requested changes Apr 15, 2022
View reviewed changes
Copy link
Member

@kzadorozhny kzadorozhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the build failures and add 5.0.0 to the CI test matrix.

@uajith uajith requested a review from kzadorozhny April 18, 2022 11:49
kzadorozhny
kzadorozhny requested changes Apr 20, 2022
View reviewed changes
Copy link
Member

@kzadorozhny kzadorozhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove duplicate exe[PushInfo].repository output from the push script output

skylib/kustomize/kustomize.bzl Outdated Show resolved Hide resolved
@uajith uajith requested a review from kzadorozhny April 21, 2022 13:53
@kzadorozhny kzadorozhny merged commit 758bbc3 into adobe:master Apr 22, 2022
arturo-skydio pushed a commit to Skydio/rules_gitops that referenced this pull request Jan 14, 2023
@uajith @arturo-skydio
Remove use of PushInfo(tag) form push.bzl (adobe#90)
780d20f
@arturo-skydio arturo-skydio mentioned this pull request Jan 14, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzadorozhny kzadorozhny kzadorozhny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uajith @kzadorozhny