fix(revert): remove slack targets type

adobe · Feb 5, 2024 · dbd64d4 · dbd64d4
1 parent c96391c
commit dbd64d4
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 22 deletions.
diff --git a/packages/spacecat-shared-slack-client/src/clients/index.d.ts b/packages/spacecat-shared-slack-client/src/clients/index.d.ts
@@ -12,10 +12,8 @@
 
 // eslint-disable-next-line max-classes-per-file
 import type { UniversalContext } from '@adobe/helix-universal';
-import type { SlackChannel } from '../models';
-import { SLACK_TARGETS } from '../constants.js';
 
-type SLACK_TARGET = typeof SLACK_TARGETS[keyof typeof SLACK_TARGETS];
+import type { SlackChannel } from '../models';
 
 /**
  * Represents a Slack client that can be used to interact with the Slack API.
@@ -44,7 +42,7 @@ export class BaseSlackClient {
    * @param {string} target - The target for the Slack client, see {@link SLACK_TARGETS}.
    * @return {BaseSlackClient} The basic Slack client.
    */
-  static createFrom(context: UniversalContext, target: SLACK_TARGET): BaseSlackClient;
+  static createFrom(context: UniversalContext, target: string): BaseSlackClient;
 
   /**
    * Asynchronous method to create a RUM backlink.
@@ -91,7 +89,7 @@ export class ElevatedSlackClient extends BaseSlackClient {
    * @param {string} target - The target for the Slack client, see {@link SLACK_TARGETS}.
    * @return {ElevatedSlackClient<BaseSlackClient>} The elevated Slack client.
    */
-  static createFrom(context: UniversalContext, target: SLACK_TARGET): ElevatedSlackClient;
+  static createFrom(context: UniversalContext, target: string): ElevatedSlackClient;
 
   /**
    * Creates a new Slack channel. The channel can be public or private.

diff --git a/packages/spacecat-shared-slack-client/src/constants.js b/packages/spacecat-shared-slack-client/src/constants.js
diff --git a/packages/spacecat-shared-slack-client/src/index.d.ts b/packages/spacecat-shared-slack-client/src/index.d.ts
@@ -13,6 +13,11 @@
 import type { BaseSlackClient, ElevatedSlackClient } from './clients';
 import type { SlackChannel, SlackUser } from './models';
 
+export declare const SLACK_TARGETS: {
+  WORKSPACE_INTERNAL: string;
+  WORKSPACE_EXTERNAL: string;
+};
+
 /**
  * The possible statuses for a user invites and channel creations.
  */

diff --git a/packages/spacecat-shared-slack-client/src/index.js b/packages/spacecat-shared-slack-client/src/index.js
@@ -12,7 +12,11 @@
 
 import BaseSlackClient from './clients/base-slack-client.js';
 import ElevatedSlackClient, { SLACK_STATUSES } from './clients/elevated-slack-client.js';
-import { SLACK_TARGETS } from './constants.js';
+
+const SLACK_TARGETS = {
+  WORKSPACE_INTERNAL: 'WORKSPACE_INTERNAL',
+  WORKSPACE_EXTERNAL: 'WORKSPACE_EXTERNAL',
+};
 
 export {
   SLACK_STATUSES,