fix(accordion): simplify header sizing, remove unmanaged custom property #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Spectrum CSS documentation build successfully! 🎉 |
|
VRT successfully! 🎊 |
|
Was there anything else I could do to this PR to help move it along? |
|
@Westbrook nope, we just need to get around to it! I added it to our sprint to look at. |
GarthDB
reviewed
Oct 15, 2020
lazd
reviewed
Oct 21, 2020
lazd
reviewed
Oct 21, 2020
lazd
requested changes
Oct 21, 2020
There was a problem hiding this comment.
@Westbrook can you try it without the fallbacks and see if build output is the same? Thanks!
Westbrook
force-pushed
the
westbrook/accordion
branch
from
e6f6ffa
to
7fb72df
Compare
|
Spectrum CSS documentation build successfully! 🎉 |
|
VRT successfully! 🎊 |
|
Just realized this was still open. Let me know if there is anything I can do to help move it along. |
lazd
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #1033
supersedes #1043
--spectrum-accordion-item-height-actual--spectrum-accordion-item-height-actualcustom property (which was unmanaged across various scales)How and where has this been tested?
Screenshots
To-do list