Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breadcrumb): use flex-start for justify content #1369

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

alexander-riss
Copy link
Contributor

@alexander-riss alexander-riss commented Jan 28, 2022

ENG: this was probably a typo in the first place - autoprefixer flagged this when using spectrum-css, so fixing it here to get rid of the linter warning

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

ENG: this was probably a typo in the first place - autoprefixer flagged this when using spectrum-css, so fixing it here to get rid of the linter warning
@lazd
Copy link
Member

lazd commented Jan 28, 2022

Note that start is a valid value for justify-content, it just doesn't respect flex-direction: row-reverse, whereas flex-start does. I tested the change locally and found it doesn't break RTL, so I think we're good to merge this.

That said, can you please paste the linter error that autoprefixer was showing you? Thanks!

@alexander-riss
Copy link
Contributor Author

The warning was:
start value has mixed support, consider using flex-start instead

@alexander-riss
Copy link
Contributor Author

any other objections? this warning is effectively blocking us from migrating to create-react-app 5.0 - as autoprefixer will log this warning during build time and in this way break any CI build

@lazd
Copy link
Member

lazd commented Feb 1, 2022

LGTM!

@lazd lazd merged commit bd6c56c into adobe:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants