Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add stylelint #1787

Merged
merged 1 commit into from
Jun 1, 2023
Merged

feat: add stylelint #1787

merged 1 commit into from
Jun 1, 2023

Conversation

pfulton
Copy link
Collaborator

@pfulton pfulton commented Apr 18, 2023 •
edited by Rajdeepc
Loading

Description

  • Adds Stylelint to the project & borrows from some of the standard config.
  • Adds a new linting GH Action to allow for linting in CI.

How and where has this been tested?

  • How this was tested:
    yarn lint:styles

  • Browser(s) and OS(s) this was tested with:
    Chrome and in Github workflow

Screenshots

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested these changes in Windows High Contrast mode.
  • I have updated any relevant storybook stories and templates.
  • This pull request is ready to merge.

@pfulton pfulton force-pushed the pfulton/feat--add-stylelint branch from 30b7336 to 5fdfc1a Compare April 18, 2023 20:40
@pfulton pfulton closed this Apr 18, 2023
@pfulton pfulton reopened this Apr 18, 2023
@pfulton pfulton marked this pull request as draft April 18, 2023 20:44
castastrophe
castastrophe reviewed Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty great, whenever you're ready to bring it in, let me know and I'll pull it down for testing

.stylelintignore Show resolved Hide resolved
.stylelintrc.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023 •
edited
Loading

🚀 Deployed on https://pr-1787--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 4, 2023 06:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 9, 2023 10:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 9, 2023 12:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 9, 2023 14:31 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 9, 2023 15:05 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 9, 2023 15:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 10, 2023 17:45 Inactive
@Rajdeepc Rajdeepc marked this pull request as ready for review May 11, 2023 14:20
@github-actions github-actions bot temporarily deployed to pull request May 11, 2023 15:08 Inactive
castastrophe
castastrophe reviewed May 11, 2023
View reviewed changes
Copy link
Collaborator

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the custom-stylelint-plugins folder to just plugins? We have several custom postcss plugins as well that I'd like to eventually move out of tools.

@github-actions github-actions bot temporarily deployed to pull request May 12, 2023 05:32 Inactive
pfulton
pfulton commented May 12, 2023
View reviewed changes
Copy link
Collaborator Author

@pfulton pfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rajdeepc things are starting to take shape here! Thanks for working on this. I left a few comments - also: how do you feel about writing some tests to cover the custom plugin functionality?

@github-actions github-actions bot temporarily deployed to pull request May 12, 2023 17:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 12, 2023 19:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 14, 2023 15:24 Inactive
@Rajdeepc
Copy link
Collaborator

Rajdeepc commented May 15, 2023 •
edited
Loading

@Rajdeepc things are starting to take shape here! Thanks for working on this. I left a few comments - also: how do you feel about writing some tests to cover the custom plugin functionality?

Got it. Tests are included now. Thanks @pfulton . Would you like to do one round of review again. Did some abstraction on the codebase.

@github-actions github-actions bot temporarily deployed to pull request May 15, 2023 11:29 Inactive
@Rajdeepc Rajdeepc requested a review from castastrophe May 15, 2023 14:35
@github-actions github-actions bot temporarily deployed to pull request May 15, 2023 14:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 29, 2023 07:20 Inactive
@Rajdeepc Rajdeepc requested a review from castastrophe May 29, 2023 09:43
@github-actions github-actions bot temporarily deployed to pull request May 29, 2023 09:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 30, 2023 14:49 Inactive
@Rajdeepc Rajdeepc self-requested a review May 30, 2023 14:51
@github-actions github-actions bot temporarily deployed to pull request June 1, 2023 14:06 Inactive
@castastrophe castastrophe force-pushed the pfulton/feat--add-stylelint branch 3 times, most recently from 00b9be2 to c2cc27d Compare June 1, 2023 14:19
@github-actions github-actions bot temporarily deployed to pull request June 1, 2023 14:28 Inactive
@castastrophe castastrophe force-pushed the pfulton/feat--add-stylelint branch from c2cc27d to 0a7b6f7 Compare June 1, 2023 14:57
github-actions[bot]
github-actions bot reviewed Jun 1, 2023
View reviewed changes
components/accordion/index.css Outdated Show resolved Hide resolved
components/accordion/index.css Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request June 1, 2023 15:14 Inactive
@castastrophe castastrophe force-pushed the pfulton/feat--add-stylelint branch 3 times, most recently from e7eaf0f to 4a2ada2 Compare June 1, 2023 15:33
@github-actions github-actions bot temporarily deployed to pull request June 1, 2023 15:43 Inactive
@castastrophe
Copy link
Collaborator

I validated this PR by applying a couple different types of errors inside of the accordion/index.css file and confirmed that the action failed and that comments were added to the files in the PR. ✅

@castastrophe castastrophe force-pushed the pfulton/feat--add-stylelint branch 5 times, most recently from c02c007 to 6c10f0a Compare June 1, 2023 20:12
@castastrophe castastrophe force-pushed the pfulton/feat--add-stylelint branch from 6c10f0a to 544579a Compare June 1, 2023 20:18
@github-actions github-actions bot temporarily deployed to pull request June 1, 2023 20:27 Inactive
@pfulton pfulton merged commit a450904 into main Jun 1, 2023
@pfulton pfulton deleted the pfulton/feat--add-stylelint branch June 1, 2023 20:36
@github-actions github-actions bot mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@castastrophe castastrophe castastrophe approved these changes

@Rajdeepc Rajdeepc Awaiting requested review from Rajdeepc

Assignees
No one assigned
Labels
enhancement A request to add a feature to a component github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pfulton @Rajdeepc @castastrophe