Use language-specific fonts for CJK

[peller]

Expected Behavior

These are the fonts were were told to use for the respective locales:

ja-JP:

    font-family: 'adobe-clean-han-japanese', 'Yu Gothic', '\30E1 \30A4 \30EA \30AA', '\30D2 \30E9 \30AE \30CE \89D2 \30B4  Pro W3', 'Hiragino Kaku Gothic Pro W3', 'Osaka', '\FF2D \FF33 \FF30 \30B4 \30B7 \30C3 \30AF', 'MS PGothic', sans-serif;

zh-TW aka zh-hant:

    font-family: 'adobe-clean-han-traditional', 'MingLiu', 'Heiti TC Light', sans-serif;

zh-CN aka zh-hans and/or zh:

    font-family: 'adobe-clean-han-simplified', 'SimSun', 'Heiti SC Light', sans-serif;

ko-KO:

    font-family: 'adobe-clean-han-korean', 'Malgun Gothic', 'Apple Gothic', sans-serif;

Actual Behavior

We are seeing adobe-clean-han-japanese for all CJK locales:

.spectrum {
  font-family: adobe-clean, "Source Sans Pro", -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, sans-serif;
  font-size: 14px;
}
.spectrum:lang(zh-Hans) {
    font-family: adobe-clean-han-japanese, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, sans-serif;
  }
.spectrum:lang(zh) {
    font-family: adobe-clean-han-japanese, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, sans-serif;
  }
.spectrum:lang(ko) {
    font-family: adobe-clean-han-japanese, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, sans-serif;
  }
.spectrum:lang(ja) {
    font-family: adobe-clean-han-japanese, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, sans-serif;
  }

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Browser name/version/os (ie Chrome Version 62.0.3202.94 (Official Build) (64-bit) MacOS)

Spectrum-CSS version

2.10.0

Sample Code that illustrates the problem

Screenshots (if applicable)

[lazd]

@GarthDB can you look into this?

[GarthDB]

Yeah - there was some work left in DNA to update the default font list. I'll revisit it.

[peller]

@GarthDB please apply the same locale-specific override logic for .spectrum-Textfield

https://github.com/adobe/spectrum-css/blob/master/src/textfield/index.css#L30

[ybayer]

@GarthDB In this commit, individual CCJK Adobe Clean Han fonts are replaced with a single one just with Japanese Adobe Clean Han fonts.

  --spectrum-font-family-zh: adobe-clean-han-traditional, var(--spectrum-font-family-base);
  --spectrum-font-family-zhhans: adobe-clean-han-simplified-c, var(--spectrum-font-family-base);
  --spectrum-font-family-ko: adobe-clean-han-korean, var(--spectrum-font-family-base);
  --spectrum-font-family-ja: adobe-clean-han-japanese,  var(--spectrum-font-family-base);

 --spectrum-font-family-han: adobe-clean-han-japanese, var(--spectrum-font-fallbacks-sans);

Don't we need to keep them separately because each Adobe Clean Han fonts are different fonts? We've seen weird rendering behavior in the app for Korean, S. Chinese and T. Chinese.
In Utility Nav, even though, UI is Korean, the font stack is "adobe-clean-han-japanese" where is should be "adobe-clean-han-korean".

[lazd]

This was fixed by #248