feat(sidenav)!: core tokens migration #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1901--spectrum-css.netlify.app |
jenndiaz
force-pushed
the
jenndiaz/css-191-side-nav
branch
from
82f1223 to
f8f4fbe
Compare
jenndiaz
force-pushed
the
jenndiaz/css-191-side-nav
branch
from
5aa2a9e to
4f82222
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jenndiaz
commented
Jun 6, 2023
| /* stylelint-disable declaration-property-value-no-unknown */ | ||
| .spectrum-SideNav { | ||
| .spectrum-Icon { | ||
| forced-color-adjust: preserve-parent-color; |
There was a problem hiding this comment.
forced-color-adjust: preserve-parent-color; was new to me heres the docs I was using:
https://www.w3.org/TR/css-color-adjust-1/#valdef-forced-color-adjust-preserve-parent-color
https://developer.mozilla.org/en-US/docs/Web/CSS/forced-color-adjust
jenndiaz
force-pushed
the
jenndiaz/css-191-side-nav
branch
from
ca1d581 to
5bb7509
Compare
jenndiaz
force-pushed
the
jenndiaz/css-191-side-nav
branch
from
fe50de9 to
afd52f2
Compare
pfulton
requested changes
Jun 9, 2023
jenndiaz
force-pushed
the
jenndiaz/css-191-side-nav
branch
from
705f415 to
0a7f64a
Compare
jawinn
requested changes
Jun 13, 2023
jenndiaz
force-pushed
the
jenndiaz/css-191-side-nav
branch
from
a4d491d to
bc30962
Compare
jenndiaz
force-pushed
the
jenndiaz/css-191-side-nav
branch
from
7fa0121 to
5a1f090
Compare
This reverts commit a404f95.
pfulton
force-pushed
the
jenndiaz/css-191-side-nav
branch
from
426f13c to
3284344
Compare
pfulton
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates SideNav to use core tokens.
Implemented changes to docs site side nav.
Jira Ticket
How and where has this been tested?
Browser(s) and OS(s) this was tested with:
Chrome Version 113.0.5672.63 on macOS
Safari 16.4 on macOS
Firefox 112.0.2 on macOS
Screenshots
To-do list