-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(button): add explicit highcontrast variables for disabled color #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlogsdon18
force-pushed
the
css-534-button-color-whcm
branch
from
June 30, 2023 14:38
c29f0ed
to
8fd05f6
Compare
🚀 Deployed on https://pr-1985--spectrum-css.netlify.app |
mlogsdon18
force-pushed
the
css-534-button-color-whcm
branch
from
June 30, 2023 18:48
8fd05f6
to
9e003c4
Compare
pfulton
force-pushed
the
css-534-button-color-whcm
branch
from
June 30, 2023 20:56
9e003c4
to
62cb3df
Compare
pfulton
requested changes
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pfulton ope I don't know how I missed that! Should be good to go now, I needed that |
mlogsdon18
force-pushed
the
css-534-button-color-whcm
branch
from
July 11, 2023 12:42
689e8e0
to
6873da1
Compare
pfulton
force-pushed
the
css-534-button-color-whcm
branch
from
July 11, 2023 19:42
6873da1
to
6e728b6
Compare
pfulton
approved these changes
Jul 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In SWC, the highcontrast text color for disabled buttons was incorrect. We were not explicitly assigning that color variable, so this PR adds
--highcontrast
variables for disabled color and border color.SWC Github Issue
How and where has this been tested?
yarn link
to verify that the change does indeed make the desired update in SWCScreenshots
Current
This PR
To-do list