Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): add explicit highcontrast variables for disabled color #1985

Merged
merged 5 commits into from
Jul 11, 2023

Conversation

mlogsdon18
Copy link
Contributor

@mlogsdon18 mlogsdon18 commented Jun 30, 2023

Description

In SWC, the highcontrast text color for disabled buttons was incorrect. We were not explicitly assigning that color variable, so this PR adds --highcontrast variables for disabled color and border color.

SWC Github Issue

How and where has this been tested?

  • How this was tested: Tested using yarn link to verify that the change does indeed make the desired update in SWC

Screenshots

Current

Screenshot 2023-06-30 at 10 36 56 AM

This PR

Screenshot 2023-06-30 at 10 32 26 AM

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested these changes in Windows High Contrast mode.
  • I have updated any relevant storybook stories and templates.
  • If my change(s) include visual change(s), a designer has reviewed and approved those changes.
  • This pull request is ready to merge.

@mlogsdon18 mlogsdon18 force-pushed the css-534-button-color-whcm branch from c29f0ed to 8fd05f6 Compare June 30, 2023 14:38
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023

🚀 Deployed on https://pr-1985--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 30, 2023 14:44 Inactive
@mlogsdon18 mlogsdon18 force-pushed the css-534-button-color-whcm branch from 8fd05f6 to 9e003c4 Compare June 30, 2023 18:48
@github-actions github-actions bot temporarily deployed to pull request June 30, 2023 18:57 Inactive
@pfulton pfulton force-pushed the css-534-button-color-whcm branch from 9e003c4 to 62cb3df Compare June 30, 2023 20:56
@pfulton pfulton self-requested a review June 30, 2023 21:02
@github-actions github-actions bot temporarily deployed to pull request June 30, 2023 21:03 Inactive
Copy link
Collaborator

@pfulton pfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good, but when I view the "button - accent" page in the docs site, it looks like the font color on the default variants were negatively impacted by the changes.

Screenshot 2023-06-30 at 5 02 12 PM

@mlogsdon18
Copy link
Contributor Author

@pfulton ope I don't know how I missed that! Should be good to go now, I needed that forced-color-adjust: none on the label

@github-actions github-actions bot temporarily deployed to pull request July 3, 2023 18:05 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 3, 2023 18:32 Inactive
@mlogsdon18 mlogsdon18 force-pushed the css-534-button-color-whcm branch from 689e8e0 to 6873da1 Compare July 11, 2023 12:42
@github-actions github-actions bot temporarily deployed to pull request July 11, 2023 12:50 Inactive
@pfulton pfulton force-pushed the css-534-button-color-whcm branch from 6873da1 to 6e728b6 Compare July 11, 2023 19:42
@github-actions github-actions bot temporarily deployed to pull request July 11, 2023 19:50 Inactive
@pfulton pfulton merged commit 8697c37 into main Jul 11, 2023
@pfulton pfulton deleted the css-534-button-color-whcm branch July 11, 2023 19:58
@github-actions github-actions bot mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants