fix: icon sizing #2037
Merged
fix: icon sizing #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2037--spectrum-css.netlify.app |
update components accordingly accordion actionbutton checkbox clearbutton
removed custom code for icon size since it is the same as the default
mlogsdon18
force-pushed
the
fix--icon-sizing
branch
from
577bbf7
to
f440646
Compare
pfulton
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the Icon component (and all affected components) to no longer overwrite scale that is passed in with the icon name. Default icon sizing still exists if a scale is not passed in but an icon name and size is passed (i.e. "ChevronDown" along with a size param). This was the previous behavior. If an icon name is passed in along with the scale (i.e. "ChevronDown100") that scale will be kept and not overwritten. This allows for the few components that utilize different icon sizing than the default.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Regression testing
Validate:
To-do list
I have read the contribution guidelines.
I have updated relevant storybook stories and templates.
I have tested these changes in Windows High Contrast mode.
If my change impacts other components, I have tested to make sure they don't break.
If my change impacts documentation, I have updated the documentation accordingly.
✨ This pull request is ready to merge. ✨