Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(millercolumns)!: tokens migration #2191

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

jenndiaz
Copy link
Contributor

@jenndiaz jenndiaz commented Sep 28, 2023

Description

Migrates the MillerColumn component

Also:

  • updates asset list storybook to correctly display Files Selectable variant

Jira Ticket 509

Does not address issues within the asset list, added comment to Jira ticket for the Asset List migration detailing issues.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Tested by @jawinn

Test Outline

  1. Open the docs site for the MillerColumns component:
  • component should match the production docs site
  1. Open the storybook site for the MillerColumns component:
  • No changes to branches Selectable
  • Files Selectable should show checkmarks on the right and only for files (no check marks on folders/asset item with the right chevron)

Regression testing

Validate:

  1. A legacy documentation page (such as accordion), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive
  1. A migrated documentation page (such as action group), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive

Screenshots

To-do list

  • I have read the contribution guidelines.

  • I have updated relevant storybook stories and templates.

  • I have tested these changes in Windows High Contrast mode.

  • If my change impacts other components, I have tested to make sure they don't break.

  • If my change impacts documentation, I have updated the documentation accordingly.

  • ✨ This pull request is ready to merge. ✨

@jenndiaz jenndiaz marked this pull request as draft September 28, 2023 21:26
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

🚀 Deployed on https://pr-2191--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request September 28, 2023 21:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 29, 2023 19:30 Inactive
@jenndiaz jenndiaz marked this pull request as ready for review September 29, 2023 19:39
Copy link
Collaborator

@jawinn jawinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The only two things I saw were what you already found that are related to AssetList and not this component (dark themes appearance and indicating keyboard focus).

Comment on lines 16 to 17
--spectrum-millercolumn-margin-left: var(--spectrum-spacing-100);
--spectrum-millercolumn-margin-right: var(--spectrum-spacing-100);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two could be renamed with logical property naming? e.g. --spectrum-millercolumn-margin-inline-start

@github-actions github-actions bot temporarily deployed to pull request October 4, 2023 21:02 Inactive
@jenndiaz jenndiaz changed the title refactor!: miller columns migration refactor(millercolumns)!: tokens migration Oct 11, 2023
@pfulton pfulton force-pushed the jenndiaz/css-509-miller-migration branch from 4eea1da to c719a8e Compare October 13, 2023 13:58
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Oct 13, 2023
@github-actions github-actions bot temporarily deployed to pull request October 13, 2023 14:04 Inactive
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Oct 13, 2023
@github-actions github-actions bot temporarily deployed to pull request October 13, 2023 14:23 Inactive
@pfulton pfulton merged commit aa163d2 into main Oct 13, 2023
4 checks passed
@pfulton pfulton deleted the jenndiaz/css-509-miller-migration branch October 13, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants